Skip to content

Use repo-file-sync-action to standardise pre-commit-config.yaml#23

Merged
HGWright merged 18 commits intoSciTools:mainfrom
trexfeathers:sync-action
Apr 11, 2024
Merged

Use repo-file-sync-action to standardise pre-commit-config.yaml#23
HGWright merged 18 commits intoSciTools:mainfrom
trexfeathers:sync-action

Conversation

@trexfeathers
Copy link
Copy Markdown
Contributor

@trexfeathers trexfeathers commented Apr 8, 2024 •
edited
Loading

You can see a demo of this working here: trexfeathers/iris#88 (I tweaked certain config to temporarily make this work locally).

Don't bother looking at the commit sequence - lots of trial and error. Just look at the diff 😅

Further explanation:

.github/templates/README.md

Lines 1 to 19 in 33d12ba

These files are templates defining the standard format across all SciTools
repos. Repo deviations from template are periodically identified in pull
requests by the repo-file-sync-action.
### Possible actions on a deviation pull request
- ✔️ **Merge** - all deviations are re-aligned with the template
(E.g. the repo is simply out of date and needs updating).
- ❌ **Close** - all deviations are kept
(E.g. all deviations are required repo-specific detail).
- ️️✏️ **Edit** - re-align some deviations, keep others.
- 🏃 **Close then action independently**
(E.g. the repo contains content that should be added to the template).
### Further reading
- https://github.com/marketplace/actions/repo-file-sync-action
- [../.github/workflows/template-sync.yml](../.github/workflows/template-sync.yml)
- [../.github/template-sync.yml](../.github/template-sync.yml)

@trexfeathers trexfeathers requested a review from HGWright April 8, 2024 15:07
HGWright
HGWright reviewed Apr 10, 2024
View reviewed changes
HGWright
HGWright approved these changes Apr 10, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@HGWright HGWright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for this new GHA! @trexfeathers

@HGWright HGWright merged commit 4f50f39 into SciTools:main Apr 11, 2024
@pp-mo pp-mo mentioned this pull request May 16, 2024
Merged
@trexfeathers trexfeathers mentioned this pull request Mar 20, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HGWright HGWright HGWright approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@trexfeathers @HGWright